Skip to content

bpo-35584: Incorrect description of ^#11944

Closed
LouisMichael wants to merge 8 commits intopython:masterfrom
LouisMichael:master
Closed

bpo-35584: Incorrect description of ^#11944
LouisMichael wants to merge 8 commits intopython:masterfrom
LouisMichael:master

Conversation

@LouisMichael
Copy link
Copy Markdown

@LouisMichael LouisMichael commented Feb 19, 2019

The previous description of ^ was inaccurate since it will not match the literal ^ unescaped outside of a character class.

https://bugs.python.org/issue35584

@the-knights-who-say-ni
Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@LouisMichael LouisMichael changed the title bpo-35584: Has ^ usage reference later section. bpo-35584: Incorrect description of ^ Feb 19, 2019
@tirkarthi
Copy link
Copy Markdown
Member

Please remove trailing whitespace in the PR to fix CI.

@tirkarthi
Copy link
Copy Markdown
Member

@rhettinger I think this can be closed with #11946 merged.

@LouisMichael
Copy link
Copy Markdown
Author

I now build on #11946 and included a reference to clarify what ^ does.
Clarifying what ^ does was what was incorrect before #11946 , removing it fixes the error but does not help the reader understand this special character the first time that it is used.

@ammaraskar
Copy link
Copy Markdown
Member

I don't think introducing a forward reference to the section on ^ is useful here since it is only talking about character classes, in my opinion leaving it at Raymond's change is appropriate.

@JulienPalard
Copy link
Copy Markdown
Member

Hi @LouisMichael thank you for you pull request, that's appreciated.

Sadly, @rhettinger did #11946 in the meantime, and merged it. so I will close this one.

Sorry for this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review docs Documentation in the Doc dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants